Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent map write from llb #1668

Open
hinshun opened this issue Sep 2, 2020 · 1 comment
Open

Concurrent map write from llb #1668

hinshun opened this issue Sep 2, 2020 · 1 comment

Comments

@hinshun
Copy link
Collaborator

hinshun commented Sep 2, 2020

When marshalling more than one llb.State that share vertices.

fatal error: concurrent map writes
goroutine 181 [running]:
runtime.throw(0x23051fb, 0x15)
	/usr/local/go/src/runtime/panic.go:1112 +0x72 fp=0xc0005e4910 sp=0xc0005e48e0 pc=0x1035da2
runtime.mapassign_faststr(0x20d26e0, 0xc0003431d0, 0x22fccf8, 0x10, 0xc000452309)
	/usr/local/go/src/runtime/map_faststr.go:211 +0x3f7 fp=0xc0005e4978 sp=0xc0005e4910 pc=0x1015357
github.com/moby/buildkit/client/llb.addCap(...)
	/go/src/stash.corp.netflix.com/engtools/newt/vendor/github.com/moby/buildkit/client/llb/source.go:468
github.com/moby/buildkit/client/llb.(*ExecOp).Marshal(0xc0007a5080, 0x2597cc0, 0xc00019e008, 0xc000364540, 0xc00033f650, 0xc0005e58f0, 0xc0005e5948, 0xc0005e5918, 0xc000364540, 0xc00033f650, ...)
	/go/src/stash.corp.netflix.com/engtools/newt/vendor/github.com/moby/buildkit/client/llb/exec.go:235 +0xc72 fp=0xc0005e4ff0 sp=0xc0005e4978 pc=0x1ad4bf2
@tonistiigi tonistiigi added this to the v0.8.0 milestone Jan 11, 2021
@thaJeztah thaJeztah modified the milestones: v0.8.0, v0.8.2 Feb 4, 2021
@tonistiigi tonistiigi removed this from the v0.8.2 milestone Jul 9, 2021
@sipsma
Copy link
Collaborator

sipsma commented Feb 9, 2022

This appears to be the same issue that was causing occasional panics in mergediff tests, i.e. as mentioned here.

The issue there appeared to be that the same llb.State was being used by distinct buildkit clients running in separate goroutines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants