Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected metrics for BenchmarkBuildSecret #124

Open
crazy-max opened this issue Sep 20, 2024 · 0 comments
Open

unexpected metrics for BenchmarkBuildSecret #124

crazy-max opened this issue Sep 20, 2024 · 0 comments
Labels
area/benchmark kind/bug Something isn't working

Comments

@crazy-max
Copy link
Member

Since https://moby.github.io/buildkit-bench/#/result/20240918-081354, BenchmarkBuildSecret:

// https://github.com/docker/buildx/issues/2479
func benchmarkBuildSecret(b *testing.B, sb testutil.Sandbox) {
dockerfile := []byte(`
FROM python:latest
RUN --mount=type=secret,id=SECRET cat /run/secrets/SECRET
`)
dir := tmpdir(
b,
fstest.CreateFile("Dockerfile", dockerfile, 0600),
fstest.CreateFile("secret.txt", []byte("mysecret"), 0600),
)
b.ResetTimer()
b.StartTimer()
out, err := buildxBuildCmd(sb, withDir(dir), withArgs("--secret=id=SECRET,src=secret.txt", "."))
b.StopTimer()
sb.WriteLogFile(b, "buildx", []byte(out))
require.NoError(b, err, out)
}

does not return what we would expect.

Previously: https://moby.github.io/buildkit-bench/#/result/20240917-213205

image

Current: https://moby.github.io/buildkit-bench/#/result/20240918-081354

image

We should see the regression between v0.12.5 and v0.13.0 related to moby/buildkit#4624 as shown in previous benchs:

image

But we don't since https://moby.github.io/buildkit-bench/#/result/20240918-081354

image

Changes we made between 20240917-213205 and 20240918-081354 doesn't seem related:

88ac7cb...1b61540

@crazy-max crazy-max added kind/bug Something isn't working area/benchmark labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/benchmark kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant