Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with React Native New Architecture #2202

Open
JulienLeal opened this issue Dec 17, 2024 · 5 comments
Open

Compatibility with React Native New Architecture #2202

JulienLeal opened this issue Dec 17, 2024 · 5 comments

Comments

@JulienLeal
Copy link

Hi team,

I would like to confirm Maestro's compatibility with React Native's New Architecture (Fabric and TurboModules). As React Native evolves, tools like Detox have had some challenges with supporting the New Architecture fully.

  • Does Maestro officially support React Native's New Architecture?
  • Are there any known limitations or issues when testing apps that are built with Fabric and TurboModules enabled?

I couldn't find specific details in the documentation about this, and I want to ensure a smooth integration for my project.

Thank you in advance for your time and for building such a great tool!

Copy link

linear bot commented Dec 17, 2024

@Fishbowler
Copy link
Contributor

There's nothing in New Architecture that should prevent Maestro from working - Maestro is implementation agnostic. So long as it's still 'accessible' (in both the technical and a11y meanings) then I'd expect it to work.

I'd also expect that given how long New Architecture has been kicking around that we'd have seen a lot of complaints by now if it weren't working.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.
Thank you for helping keep us our issue tracker clean!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
@Fishbowler Fishbowler reopened this Jan 10, 2025
@Fishbowler
Copy link
Contributor

Reopening this, given some info from Slack that implies that this could end up as a bug rather than a question.

Me:

I don't believe the RN architecture is relevant to Maestro. There's no special code to deal with RN, Flutter, Kotlin MP, etc. It's all just UI components once they're rendered.

Brett:

Normally I would agree. I have run it successfully on the new arch, but the test app was pretty small. I guess the reason they are asking is because RN moved from natively rendering inputs etc, to I think with Fabric using a pixel rendering system like Flutter used to do too.

Slack Link

This could really use someone pointing at an example app in the New Architecture that would help us know one way or another.

@mobile-dev-inc mobile-dev-inc unlocked this conversation Jan 10, 2025
@JulienLeal
Copy link
Author

@Fishbowler awesome, thanks to give more context about the internal discussion.
To bring more for this, I also saw that react native is using maestro for their first e2e tests and as you can see on the source code, they're validating the new react architecture with maestro tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants