fix: reinstall ios app to clear state reliably #2118
Conversation
|
how do we make sure this is working? |
Co-authored-by: Igor Lema <48068670+igorsmotto@users.noreply.github.com>
| ) | ||
| // reinstall the app as that is the most stable way to clear state | ||
| reinstallApp(deviceId, bundleId) | ||
| } |
There was a problem hiding this comment.
This could break the current maestro flows for all the users right? How do we plan to roll this out?
Do we wait to bring on cloud/robin or we do it right away?
Should this be in next release or we include in this current version of CLI as 1.39.1?
There was a problem hiding this comment.
I am torn - the fact is that clearState is not working properly today, so the fact that we fix it means that flows that implicitly rely on the broken state of clearState might stop working. However, it's a bug fix and not a breaking change so doing a major version bump doesn't feel right. Thoughts?
There was a problem hiding this comment.
This could break the current maestro flows for all the users right?
Wait, how? Like, do you have any idea? We could potentially test this more to reduce this risk
There was a problem hiding this comment.
About versioning, to me it's a bug fix. Clear state being flaky since forever is a bug
There was a problem hiding this comment.
Wait, how? Like, do you have any idea? We could potentially test this more to reduce this risk
Users would have made their flows adapting to the current bug. So, the flows could break when this is actually fixed.
I am torn - the fact is that clearState is not working properly today, so the fact that we fix it means that flows that implicitly rely on the broken state of clearState might stop working. However, it's a bug fix and not a breaking change so doing a major version bump doesn't feel right. Thoughts?
TBH, I am in favour of fully rolling this out without any hacks on backend. Given we emphasize that it could potentially break flows, I think its ok.
Around the rollout, I feel this not requires a major version bump but we should maybe just release (1.39.1) instead of waiting this to get in 1.40.0. Get this in cloud, robin and CLI as a quick follow up instead of waiting for 1.40.0 WDYT?
* fix: reinstall ios app to clear state reliably * Update maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt Co-authored-by: Igor Lema <48068670+igorsmotto@users.noreply.github.com> --------- Co-authored-by: Igor Lema <48068670+igorsmotto@users.noreply.github.com>
* fix: reinstall ios app to clear state reliably * Update maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt Co-authored-by: Igor Lema <48068670+igorsmotto@users.noreply.github.com> --------- Co-authored-by: Igor Lema <48068670+igorsmotto@users.noreply.github.com>
Proposed changes
Reinstall the app and then launch it instead of manually trying to delete app state folders, which should improve the experience when relying on clear state to have a completely blank slate in the app.
Relates to #1601