Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix samples #1962

Merged
merged 19 commits into from
Aug 29, 2024
Merged

Fix samples #1962

merged 19 commits into from
Aug 29, 2024

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Aug 28, 2024 •
edited
Loading

The samples were outdated. The flows in the samples don't pass.

This PR attempts to:

  • update the samples so all tests pass
  • automates updating the samples
  • hooks samples up into our e2e testing pipeline

@bartekpacia
Copy link
Contributor Author

bartekpacia commented Aug 28, 2024 •
edited
Loading

Stuff missing:

  • platform specifier in the flow frontmatter.
    • Workaround 1: separate android and ios directories
    • Workaround 2: android and ios tags (I went with this)

@bartekpacia bartekpacia marked this pull request as ready for review August 29, 2024 11:42
@bartekpacia bartekpacia force-pushed the fix/samples branch 2 times, most recently from 390a9b8 to ec8bf2e Compare August 29, 2024 13:04
@bartekpacia bartekpacia force-pushed the fix/samples branch 4 times, most recently from a28f4dc to e9c9d62 Compare August 29, 2024 13:36
@bartekpacia bartekpacia merged commit a617b61 into main Aug 29, 2024
3 of 4 checks passed
@bartekpacia bartekpacia deleted the fix/samples branch August 29, 2024 15:47
@bartekpacia bartekpacia mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartekpacia