Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Static cache makes multiple and different consecutive twig template loading to fail #120

Open
DiegoPino opened this issue Aug 20, 2020 · 0 comments
Assignees

Comments

@DiegoPino
Copy link
Contributor

What?

Ok, short story. I added static caching to all DB based functions in IMI. But, most of them are not well written 😢 because i was in the hurry. Basically they are unaware of the arguments passed to the functions and in a case of final ingest, where many times the same function is called, let's say different Twig templates for each CMODEL and a few different per Datastreams (different for DC v/s MODS). Currently this code is WRONG and makes no sense, i must have been under a lot of stress when i wrote that
https://github.com/mnylc/islandora_multi_importer/blob/master/includes/utilities.inc#L376-L405

Fix? Quite simple... pulling now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant