Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Faraday's own instrumentation middleware? #20

Open
franzliedke opened this issue Jul 7, 2020 · 2 comments
Open

Use Faraday's own instrumentation middleware? #20

franzliedke opened this issue Jul 7, 2020 · 2 comments

Comments

@franzliedke
Copy link
Contributor

Apparently Faraday added instrumentation support (via middleware) lately, or I missed this when originally implementing our own instrumentation layer in #11.

Using the official one (public API, basically) would feel a bit safer to me.

See https://lostisland.github.io/faraday/middleware/instrumentation.
@jgraichen
Copy link
Member

There would still be the issue on how to enable for all clients included clients initialized in some libraries?

@franzliedke
Copy link
Contributor Author

Yeah, and if it's really a new feature (not sure to be honest) it might not work for all versions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franzliedke @jgraichen