-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stream.filter to filter signals from the stream #105
Comments
@larsoner I would like to start looking into this one, I remember you mentioned |
For realtime applications I would expect an IIR filter with
|
Great, that's similar to what I added a couple of years ago to the current viewer: mne-lsl/mne_lsl/stream_viewer/scope/scope_eeg.py Lines 122 to 128 in 9515159
I just re-read the background on filtering tutorial, and IMO, if someone wants to apply 2 different filters to 2 different channels within the Stream, it falls upon him to handle the difference in filter response. Do you agree or do you think we should prevent some combinations/parameters (order, transition bandwidth, ..)? In the case of 2 different filters applied to 2 different channels, is it possible to combined the Same questions in the case of 2 different filters applied to the same channels, e.g. bandpass (1, 100) Hz + notch (50, 100) Hz, can we combine the coefficients and call |
Do people want different filtering on different channels? If they do in principle then I would from the start plan on having N different filters each with a set of
For this you can, yeah. SOS is really a way of turning say a 10th order filter into 5 2nd order filters, then (by linearity) equivalently filtering sequentially rather than all at once, which is more numerically stable. So if you have multiple SOS filters you can just concatenate the coefficients and it should work. |
Stream filter API should allow:
In practice, we have:
The API should support:
The text was updated successfully, but these errors were encountered: