Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle menu issue on minimal mistakes website #1987

Closed
kulbhushanchand opened this issue Dec 5, 2018 · 6 comments
Closed

Toggle menu issue on minimal mistakes website #1987

kulbhushanchand opened this issue Dec 5, 2018 · 6 comments

Comments

@kulbhushanchand
Copy link
Contributor

kulbhushanchand commented Dec 5, 2018

Environment

On minimal mistakes website

Expected behavior

The toggle menu should close

Steps to reproduce the behavior

Click few times on hamburger icon (I managed to catch the bug on fourth click),
I have checked on this particular page -
https://mmistakes.github.io/minimal-mistakes/docs/quick-start-guide/

2018-12-05_13-24-20

@mmistakes
Copy link
Owner

mmistakes commented Dec 5, 2018

The menu doesn't currently close when clicking outside of the drop down nav. There was an old issue to build this feature in. I don't have a fix for it, but if someone wants to take it, have at it.

There's some weirdness with the click event that when you move the pointer off the toggle button it closes the dropdown after x amount of time.... but not always. I have no idea what's going on which is why I haven't fixed it.

@mmistakes
Copy link
Owner

Also seems to only happen in Chrome.

@kulbhushanchand
Copy link
Contributor Author

kulbhushanchand commented Dec 6, 2018

Same thing with follow button, clicking outside does not closes the menu.

image

@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Status: Stale label Jan 15, 2019
@ghost
Copy link

ghost commented Jan 28, 2019

The menu doesn't currently close when clicking outside of the drop down nav.

Chrome has some kind of assist behavior to close popovers triggered when clicking outside the popover region. I noticed it while creating a popover toolbar. Rather than trying to delegate and capture all click events at the documentElement I found it easier to simply collapse the popups when the user starts scrolling. IMO it's a Chrome bug but most would call it a feature. There are some new selectors coming in like :focus-within which should help this long time issue on the Web.

@stale stale bot removed the Status: Stale label Jan 28, 2019
@stale
Copy link

stale bot commented Feb 27, 2019

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants