Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates are not showing on iOS #293

Closed
EdmundMai opened this issue Oct 3, 2019 · 7 comments
Closed

Dates are not showing on iOS #293

EdmundMai opened this issue Oct 3, 2019 · 7 comments
Labels

Comments

@EdmundMai
Copy link

Environment

info
  React Native Environment Info:
    System:
      OS: macOS 10.14.6
      CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
      Memory: 1.81 GB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 12.6.0 - /usr/local/bin/node
      Yarn: 1.15.2 - /usr/local/bin/yarn
      npm: 6.11.3 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
      Android SDK:
        API Levels: 29
        Build Tools: 29.0.2
        System Images: android-29 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.5 AI-191.8026.42.35.5791312
      Xcode: 10.3/10G8 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: https://github.com/expo/react-native/archive/sdk-35.0.0.tar.gz => 0.59.8
    npmGlobalPackages:
      react-native-cli: 2.0.1
      react-native-log-ios: 1.0.1


Platforms

iOS

Versions

Description

image

image

Reproducible Demo

import React, { useState } from "react";
import DateTimePicker from "react-native-modal-datetime-picker";
import { View, Text, TouchableOpacity } from "react-native";

const Notifications = () => {
  const [isDatePickerVisible, setIsDatePickerVisible] = useState(false);

  return (
    <View>
      <TouchableOpacity onPress={() => setIsDatePickerVisible(true)}>
        <Text>Click me</Text>
      </TouchableOpacity>
      <DateTimePicker
        isVisible={isDatePickerVisible}
        mode="time"
        onConfirm={time => {
          setIsDatePickerVisible(false);
        }}
        onCancel={() => setIsDatePickerVisible(false)}
      />
    </Container>
  );
};

export default Notifications;

@EdmundMai EdmundMai added the bug label Oct 3, 2019
@EdmundMai
Copy link
Author

This is happening on a iPhone 7 by the way

@mmazzarolo
Copy link
Owner

@EdmundMai thanks for reporting. This seems somewhat related to #283 .
I guess it's just in Expo? Not sure why though...
Do you mind checking if #262 fixes your issue?

@EdmundMai
Copy link
Author

@mmazzarolo I think it could be the dark mode stuff! That person's screenshot looks the same. I'll take a look at it

@mmazzarolo
Copy link
Owner

@EdmundMai did you recently update Expo? I don't get what started causing this issue, if it is a change on our side or something different happening on Expo 🤔

@mmazzarolo
Copy link
Owner

Might be related: facebook/react-native#26299

@EdmundMai
Copy link
Author

These instructions worked: https://github.com/mmazzarolo/react-native-modal-datetime-picker#is-the-ios-dark-mode-supported

Thanks a lot for the help!

@mmazzarolo
Copy link
Owner

Glad it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants