Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dialog.Title disappears on android with dark mode ON #156

Open
nimeshmaharjan1 opened this issue Mar 18, 2024 · 3 comments
Open

The Dialog.Title disappears on android with dark mode ON #156

nimeshmaharjan1 opened this issue Mar 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@nimeshmaharjan1
Copy link

Platforms

Only on Android

Versions

  • "expo": "~50.0.13",
  • "react-native-dialog": "^9.3.0",
  • "react-native": "0.73.5",
  • "react": "18.2.0",

Reproducible Demo

change the appearance to dark mode

   <Dialog.Container
                    onBackdropPress={() => setShowDeleteDialog(false)}
                    visible={showDeleteDialog}
                  >
                    <Dialog.Title>Delete Request</Dialog.Title>
                    <Dialog.Description>
                      Are you sure you want to delete this material request?
                    </Dialog.Description>
                    <Dialog.Button
                      onPress={() => setShowDeleteDialog(false)}
                      label="Cancel"
                    ></Dialog.Button>
                    <Dialog.Button
                      onPress={() =>
                        deleteMutation.mutate(query.data.payload.id)
                      }
                      label="Delete"
                    ></Dialog.Button>
                  </Dialog.Container>
@nimeshmaharjan1 nimeshmaharjan1 added the bug Something isn't working label Mar 18, 2024
@WeeJeWel
Copy link

WeeJeWel commented Apr 5, 2024

+1, but also happens without dark mode in my simulator.

Screenshot 2024-04-05 at 19 40 44

@barrettpyke
Copy link

barrettpyke commented Jun 6, 2024

You can resolve this by applying color directly to the title like...
<Dialog.Title style={Platform.OS === 'android' ? { color: 'black' } : {}}>Test Input</Dialog.Title>

EDIT: Same thing happens with Dialog.Input text and can be resolved by same styling as above

@andreasbroch2
Copy link

+1. The applying color directly works fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants