short circuit BuildPieceHashes

mmanela · Jul 13, 2024 · 015abba · 015abba
1 parent 6068ce9
commit 015abba
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/DiffPlex/Differ.cs b/DiffPlex/Differ.cs
@@ -7,9 +7,6 @@ namespace DiffPlex
 {
     public class Differ : IDiffer
     {
-
-        private static readonly string[] emptyStringArray = new string[0];
-
         /// <summary>
         /// Gets the default singleton instance of differ instance.
         /// </summary>
@@ -328,10 +325,15 @@ private static void BuildModificationData
 
         private static void BuildPieceHashes(IDictionary<string, int> pieceHash, ModificationData data, bool ignoreWhitespace, IChunker chunker)
         {
-            var pieces = string.IsNullOrEmpty(data.RawData)
-                ? emptyStringArray
-                : chunker.Chunk(data.RawData);
+            if (string.IsNullOrEmpty(data.RawData))
+            {
+                data.Pieces = [];
+                data.HashedPieces = [];
+                data.Modifications = [];
+                return;
+            }
 
+            var pieces = chunker.Chunk(data.RawData);
             data.Pieces = pieces;
             data.HashedPieces = new int[pieces.Count];
             data.Modifications = new bool[pieces.Count];
@@ -351,6 +353,7 @@ private static void BuildPieceHashes(IDictionary<string, int> pieceHash, Modific
                     pieceHash[piece] = pieceHash.Count;
                 }
             }
+
         }
     }
 }