From 07290b4e29ee0bd573c971a4acf5236a9ac37502 Mon Sep 17 00:00:00 2001 From: Maximilian Muecke Date: Mon, 5 Feb 2024 11:15:21 +0100 Subject: [PATCH] fix: fix showplot check for dbscanfpc and fix bracket for dbscan --- R/LearnerClustDBSCAN.R | 2 +- R/LearnerClustDBSCANfpc.R | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/R/LearnerClustDBSCAN.R b/R/LearnerClustDBSCAN.R index cedbf177..91366ce5 100644 --- a/R/LearnerClustDBSCAN.R +++ b/R/LearnerClustDBSCAN.R @@ -24,7 +24,7 @@ LearnerClustDBSCAN = R6Class("LearnerClustDBSCAN", eps = p_dbl(lower = 0, tags = c("required", "train")), minPts = p_int(lower = 0L, default = 5L, tags = "train"), borderPoints = p_lgl(default = TRUE, tags = "train"), - weights = p_uty(tags = "train"), custom_check = crate(check_numeric), + weights = p_uty(tags = "train", custom_check = crate(check_numeric)), search = p_fct(levels = c("kdtree", "linear", "dist"), default = "kdtree", tags = "train"), bucketSize = p_int(lower = 1L, default = 10L, tags = "train"), splitRule = p_fct(levels = c("STD", "MIDPT", "FAIR", "SL_MIDPT", "SL_FAIR", "SUGGEST"), default = "SUGGEST", tags = "train"), diff --git a/R/LearnerClustDBSCANfpc.R b/R/LearnerClustDBSCANfpc.R index b46a1e12..91276740 100644 --- a/R/LearnerClustDBSCANfpc.R +++ b/R/LearnerClustDBSCANfpc.R @@ -25,7 +25,7 @@ LearnerClustDBSCANfpc = R6Class("LearnerClustDBSCANfpc", method = p_fct(levels = c("hybrid", "raw", "dist"), tags = "train"), seeds = p_lgl(default = TRUE, tags = "train"), showplot = p_uty(default = FALSE, tags = "train", custom_check = crate(function(x) { - if (test_flag(x) && test_int(x, lower = 0, upper = 2)) { + if (test_flag(x) || test_int(x, lower = 0, upper = 2)) { TRUE } else { "`showplot` need to be either logical or integer between 0 and 2"