Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xyObjectMinMaxValues function #279

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

targos
Copy link
Member

@targos targos commented Dec 16, 2024

No description provided.

@targos targos requested a review from Copilot December 16, 2024 13:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/tests/snapshots/index.test.ts.snap: Language not supported
  • src/x/xMinMaxValues.ts: Evaluated as low risk
  • src/xyObject/tests/xyObjectCheck.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)

src/xyObject/xyObjectCheck.ts:12

  • The comment should be corrected to: 'Throws an error if it's not an array of x,y objects.'
 * Throws an error in not an array of x,y objects.

src/x/xCheck.ts:6

  • [nitpick] The comment should be capitalized consistently. Suggested: 'Minimum Length'
* Minimum length

src/x/xCheck.ts:14

  • [nitpick] The comment should be clearer. Suggested: 'Only checks the first element of the array.'
* Only checks the first element.
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (727a0d4) to head (4cd41a9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   96.27%   96.28%   +0.01%     
==========================================
  Files         182      183       +1     
  Lines        5016     5040      +24     
  Branches     1137     1147      +10     
==========================================
+ Hits         4829     4853      +24     
  Misses        187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos targos requested a review from lpatiny December 16, 2024 13:50
@targos targos merged commit dd09ee3 into main Dec 16, 2024
10 checks passed
@targos targos deleted the xyObjectMinMaxValues branch December 16, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants