Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code or bug in xNoiseSanPlot #233

Closed
targos opened this issue Mar 12, 2024 · 1 comment · Fixed by #253
Closed

Dead code or bug in xNoiseSanPlot #233

targos opened this issue Mar 12, 2024 · 1 comment · Fixed by #253

Comments

@targos
Copy link
Member

targos commented Mar 12, 2024

The variables assigned here are not used after the assignment:

initialNoiseLevelPositive = initialNoiseLevelPositive / correctionFactor;
initialNoiseLevelNegative = initialNoiseLevelNegative / correctionFactor;

/cc @lpatiny @wadjih-bencheikh18 who worked on this code.

@jobo322
Copy link
Member

jobo322 commented Mar 12, 2024

I transpile the code from Matlab Damien code. This multiplication appears in the original code but we do not export those initial values. It seems it was my fault

@jobo322 jobo322 linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants