fix: fix new width in broad singlet peak #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 94.13% 94.33% +0.19%
==========================================
Files 10 10
Lines 307 300 -7
Branches 114 114
==========================================
- Hits 289 283 -6
+ Misses 18 17 -1 ☔ View full report in Codecov by Sentry. |
lpatiny
reviewed
Mar 5, 2024
|
|
||
| if (equallySpaced) { | ||
| if (smoothY) { | ||
| yData = sgg(y, x[1] - x[0], { | ||
| windowSize, | ||
| polynomial, | ||
| ...sgOptions, |
There was a problem hiding this comment.
Do we send other parameters that just windowSize and polynomial ?
If sgg does not change the options (like adding a new parameter) and this would be a bug in sgg I think, you don't need to create a new object with destructuring sgOptions. You can directly send sgOptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.