Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid SQL error log #120

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Avoid SQL error log #120

merged 3 commits into from
Jan 23, 2025

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Jan 23, 2025

Fixes #119

Okay, turns out this was working after all but very misleading.
I did see

image

But we already deal with this in:

def get_experiment_by_name(self, experiment_name):
request = GetExperimentByName(experiment_name=experiment_name)
try:
response = self.service.call_endpoint(
get_lib().TrackingServiceGetExperimentByName, request
)
return Experiment.from_proto(response.experiment)
except MlflowException as e:
if e.error_code == databricks_pb2.ErrorCode.Name(
databricks_pb2.RESOURCE_DOES_NOT_EXIST
):
return None
raise

Signed-off-by: nojaf <florian.verdonck@outlook.com>
@nojaf nojaf requested a review from dsuhinin January 23, 2025 14:40
nojaf and others added 2 commits January 23, 2025 16:36
Signed-off-by: nojaf <florian.verdonck@outlook.com>
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nojaf nojaf changed the title Avoid SQL error log by using .Find Avoid SQL error log Jan 23, 2025
@nojaf nojaf merged commit 72b9167 into mlflow:main Jan 23, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlflow.set_experiment doesn't find newly created experiment
2 participants