Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers can't focus tracks table item if there is only one #9548

Closed
mixxxbot opened this issue Aug 23, 2022 · 9 comments
Closed

controllers can't focus tracks table item if there is only one #9548

mixxxbot opened this issue Aug 23, 2022 · 9 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2018-12-15T14:49:33Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1808632
Tags: easy, library


Reproduce:

  • go to Tracks
  • type search terms that would yield exactly one result
    = one item/row in tracks table
  • move focus to tracks table (Tab or controller key)
  • try to focus/select the one row
    = neither up/down arrows (keyboard) or [Library],MoveVertical or [..],ScrollVertical allow to focus the item

But pressing the right arrow key does select the row. It seems the leftmost table cell has 'focus' somehow but the row isn't selected.

master (2.3) 2018-12-15

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2018-12-15T21:46:48Z


I can confirm the issue with Mixxx 1.2.5 as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-06-27T10:32:31Z


@daschuer What easy solution do you propose?

In wtracktableview.cpp I'd like to select a single row automatically (in any feature/track model), but how would I retrieve the number of rows?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-06-28T23:08:10Z


I do not have a recipe for an easy fix.

I think I would start using gdb and investigate the call stack that is used when more tracks are there and a s new one is highlighted. Than I would use a one track table and repeat the test with a braekpoint a bit down in the call tree. Are you able to single step though the code?

Maybe you can than find out, why it does not work with one track and fix it finally.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-07-09T18:57:36Z


So far I used gdb only to create crash reports.
I'll see if I can wrap my head around that, but I'm afraid this won't happen soon as there are other issues more itching and more likely for me to solve them.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-09-11T12:30:27Z


So far I've found out that the first table row is always soemhow focused but not selected/highlighted.

In wtracktableview.cpp I can manually select the first row if there's only one, but that would only work for [Playlist],MoveSelection controls, not for Up/Down key presses (real or emulated in librarycontrol.cpp). The issue seems to be in qabstractitemview or qtableview respectively.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-29T09:03:19Z


#3049

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-29T09:12:21Z


#⁠3049 that enforces a selection on FocusIn events of WLibraryTableView:
no previously focused item: select first
previously focused item, but no selection: select previous item

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-28T00:49:25Z


#3090

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant