document production builds and catch-all #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two sections in the readme would have been very useful to me, hopefully others find it useful. It was not obvious to me production builds would not log or throw until I looked through the source code. While looking at the source code, I found tests for throwOnUnhandled which I found extremely useful. I work on a large team, and not everyone is deeply experienced in Ember. There is nothing preventing warnings from finding their way into the logs. Someone on the team referenced an old stack overflow answer which introduced a deprecation. Now that we have zero deprecation warnings, we want to keep it that way by forcing tests to fail.
rwjblue
approved these changes
Nov 20, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two sections in the
readmewould have been very useful to me, hopefully others find it useful. It was not obvious to me production builds would notlogorthrowuntil I looked through the source code. While looking at the source code, I found tests forthrowOnUnhandledwhich I found extremely useful. I work on a large team, and not everyone is deeply experienced in Ember. There is nothing preventing warnings from finding their way into the logs. Someone on the team referenced an old stack overflow answer which introduced a deprecation. Now that we have zero deprecation warnings, we want to keep it that way by forcing tests to fail.