Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering a deprecation handler after workflow doesn't work #113

Closed
mixonic opened this issue May 27, 2021 · 1 comment · Fixed by #114
Closed

Registering a deprecation handler after workflow doesn't work #113

mixonic opened this issue May 27, 2021 · 1 comment · Fixed by #114
Labels
2.0 2.0 blockers, see https://github.com/mixonic/ember-cli-deprecation-workflow/issues/109

Comments

@mixonic
Copy link
Member

mixonic commented May 27, 2021

Filing for @runspired

after digging in it seems the issue with not being able to register a handler was that ember-cli-deprecation-workflow was (IS still until https://github.com/mixonic/ember-cli-deprecation-workflow/pull/107/files lands) using ember-debug-handlers-polyfill which appears to clobber the deprecation handler in newer versions of ember (at least as of a year ago), potentially due to issues around ember global vs ember modules.

At https://github.com/ember-polyfills/ember-debug-handlers-polyfill/blob/master/vendor/ember-debug-handlers-polyfill/debug.js the implementation of the registerDeprecationHandler system is indeed squashed on the Ember global, but should only squashed if a prior implementation is not found https://github.com/ember-polyfills/ember-debug-handlers-polyfill/blob/master/vendor/ember-debug-handlers-polyfill/debug.js#L135

I haven't confirmed this, or what versions of Ember it impacts. Maybe @runspired has more.
@mixonic mixonic added the 2.0 2.0 blockers, see https://github.com/mixonic/ember-cli-deprecation-workflow/issues/109 label May 27, 2021
@mixonic mixonic mentioned this issue May 27, 2021
Open
mixonic added a commit that referenced this issue May 27, 2021
@mixonic
Drop debug handler polyfill
29ee0d7 
This dependency is only requires for Ember versions through 2.1, however
on master support for pre-2.12 has been dropped.

Fixes #113
@mixonic mixonic mentioned this issue May 27, 2021
Merged
mixonic added a commit that referenced this issue May 27, 2021
@mixonic
Drop debug handler polyfill
be97b88 
This dependency is only requires for Ember versions through 2.1, however
on master support for pre-2.12 has been dropped.

Fixes #113
@mixonic
Copy link
Member Author

mixonic commented May 27, 2021

@runspired this should be resolved on master via removal of the polyfill, but please confirm. I didn't attempt to figure out my own reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 2.0 blockers, see https://github.com/mixonic/ember-cli-deprecation-workflow/issues/109
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop debug handler polyfill ember-cli/ember-cli-deprecation-workflow
1 participant
@mixonic