From 1f40fcd3b8915b8385953f3fa289fe8e1039494d Mon Sep 17 00:00:00 2001 From: ryneeverett Date: Sun, 4 Dec 2016 23:10:26 -0500 Subject: [PATCH] Return True on successfull Repo.upgrade(). `pipsi upgrade` currently exits with status code 1 and does not print "Done". --- pipsi.py | 2 ++ testing/test_repo.py | 1 + 2 files changed, 3 insertions(+) diff --git a/pipsi.py b/pipsi.py index f28639d..ae84f10 100644 --- a/pipsi.py +++ b/pipsi.py @@ -304,6 +304,8 @@ def upgrade(self, package, editable=False): except (IOError, OSError): pass + return True + def list_everything(self): venvs = {} python = '/Scripts/python.exe' if IS_WIN else '/bin/python' diff --git a/testing/test_repo.py b/testing/test_repo.py index cc00090..190e262 100644 --- a/testing/test_repo.py +++ b/testing/test_repo.py @@ -34,6 +34,7 @@ def test_simple_install(repo, home, bin, package, glob): repo.install(package) assert home.join(package).check() assert bin.listdir(glob) + assert repo.upgrade(package) @pytest.mark.xfail(sys.version_info[0] != 3,