Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize user-provided LDFLAG parameters #3129

Merged
merged 9 commits into from
Feb 17, 2025
Merged

Conversation

uruwhy
Copy link
Contributor

@uruwhy uruwhy commented Feb 10, 2025

Description

Sanitize user-provided LDFLAG values for custom golang compilation to avoid RCE.

Creates new static methods that can be used by plugins such as sandcat and manx

Sandcat PR: mitre/sandcat#443
Manx PR: mitre/manx#45

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests
Tested with sandcat and manx plugins

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@elegantmoose elegantmoose merged commit 32adbf5 into master Feb 17, 2025
7 of 11 checks passed
@elegantmoose elegantmoose deleted the sanitize-param branch February 17, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants