Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update health_api.py #2412

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Update health_api.py #2412

merged 1 commit into from
Dec 20, 2021

Conversation

aapplebaum
Copy link
Contributor

Added description tag to response_schema

Description

(insert summary)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Added description tag to response_schema
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! Your first PR -- thanks for contributing!

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2412 (2f5a655) into master (7e323ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2412   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         112      112           
  Lines        8068     8068           
=======================================
  Hits         5908     5908           
  Misses       2160     2160           
Impacted Files Coverage Δ
app/api/v2/handlers/health_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e323ea...2f5a655. Read the comment docs.

Copy link
Contributor

@wbooth wbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aapplebaum aapplebaum merged commit ba85082 into master Dec 20, 2021
@aapplebaum aapplebaum deleted the aapplebaum-patch-1 branch December 20, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants