-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved confetti.min.js to core library, updated training plugin with completed certificate message #2342
Conversation
…ompleted certificate message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The confetti is a must have 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes work. good to go.
2bfa59e
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 110 110
Lines 7946 7946
=======================================
Hits 5769 5769
Misses 2177 2177 Continue to review full report at Codecov.
|
…ompleted certificate message (#2342)
Description
Confetti.min.js is no longer working in training plugin due to import issues with Alpine, now moved to shared core library so it can preloaded before the training plugin. Pinned training plugin to latest version.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: