Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-3044] Silence Schema Warnings #2333

Closed

Conversation

bleepbop
Copy link
Contributor

Description

Note: associated with #2324
When the request schema is modified in the aiohttp_apispec.request decorator, a "multiple schema" warning will be logged. There are no errors associated with this message; marshmallow simply logs this message to make sure users know that schema fields have been included/excluded. This PR silences those warnings.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Verified manually that "Duplicate Schema" warnings are silenced in the server output.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • [NA] I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2333 (20e6ea5) into master (c121153) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
- Coverage   72.62%   72.60%   -0.02%     
==========================================
  Files         110      110              
  Lines        7942     7944       +2     
==========================================
  Hits         5768     5768              
- Misses       2174     2176       +2     
Impacted Files Coverage Δ
server.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c121153...20e6ea5. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bleepbop bleepbop closed this Oct 22, 2021
@elegantmoose elegantmoose deleted the bleepbop/VIRTS-3044/silence-marshmallow-warnings branch February 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant