-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin link ID storage fix #2187
Conversation
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2187 +/- ##
=======================================
Coverage 72.62% 72.62%
=======================================
Files 110 110
Lines 7942 7942
=======================================
Hits 5768 5768
Misses 2174 2174
Continue to review full report at Codecov.
|
I'm getting an error when running a 54ndc47 agent. Seems like the instantiated agent still has |
You'll need to make sure your gocat repo is using the branch from mitre/gocat#59 - unfortunately, I had to make changes to both the core platform code and the agent code itself. @bleepbop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an error when running a 54ndc47 agent. Seems like the instantiated agent still has
origin_link_id
as an int, because in the project logs I'm getting anERROR (contact_http.py:40 _beacon) Malformed beacon: {'origin_link_id': ['Not a valid string.']}
. HTML/TCP agents are working thoughYou'll need to make sure your gocat repo is using the branch from mitre/gocat#59 - unfortunately, I had to make changes to both the core platform code and the agent code itself. @bleepbop
Sorry, missed that before. Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I think an update to the documentation regarding Lateral Movement Tracking should probably have a note about origin_link_id
being a string instead.
Good idea - I'll make a PR for fieldmanual |
Description
Since link IDs are now UUID strings, we will change the agent's
origin_link_id
field to be stored as a string rather than as an integer.This will help address origin link ID issues in #2162
Requires mitre/gocat#59
Type of change
How Has This Been Tested?
Updated and ran tests.
Checklist: