Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Approve Function bug #2717

Closed
IGNFIfortrue opened this issue Jan 12, 2023 · 15 comments
Closed

Manual Approve Function bug #2717

IGNFIfortrue opened this issue Jan 12, 2023 · 15 comments
Assignees
Labels

Comments

@IGNFIfortrue
Copy link

Describe the bug
as screenshots show, when I choose 'manual approve' before launching an oepration, the commands/links will be paused after I run the operation, and there is no button or choice to manually approve the commands

To Reproduce
Steps to reproduce the behavior:

  1. start the operation with 'require manual approval' in advance function -> autonomous,
  2. the commands will auto pasue and no reaction any longer

Screenshots
image

image

Desktop (please complete the following information):

  • OS: kali linux
  • Browser firefox
@L015H4CK
Copy link
Contributor

Hello, I just tried running an operation with the "Require manual approval" option.
After starting the operation, a button "Review Command" appeared in the "Link Command" column where I could successfully discard or approve a command.

I tested with Caldera 4.1.0 on Kali Linux and Firefox browser.

Did you check the server logs (server.py using -l DEBUG)? Maybe something went wrong?
I also wonder, why your second agent has a number as identifier?

PS: I am no caldera official - just a user.

@IGNFIfortrue
Copy link
Author

Hello, I just tried running an operation with the "Require manual approval" option. After starting the operation, a button "Review Command" appeared in the "Link Command" column where I could successfully discard or approve a command.

I tested with Caldera 4.1.0 on Kali Linux and Firefox browser.

Did you check the server logs (server.py using -l DEBUG)? Maybe something went wrong? I also wonder, why your second agent has a number as identifier?

PS: I am no caldera official - just a user.

Hello L015H4CK,

Thank you for your reply, I guess I truly meet a bug since there is no "Review Command" button on my side, I will try your suggestion later.
For the second agent with a number-identifier, I guess it is because that I deploy it using udp instead of HTTP.

@L015H4CK
Copy link
Contributor

Someone also already mentioned this three weeks ago (in discussion #2710).
I still could not replicate the problem.

Have you tried using --fresh when starting the server to see if the error persists?

@pbmilley
Copy link

I'm having this exact same problem. I've tried using Firefox on Kali (the same host running the Caldera server) and another Linux system with a Chromium browser (Vivaldi). Both had the same result as above - the operation starts and pauses on the first task, and there is no "Review Command" button to be found anywhere on the page.

I've run the server with "-l DEBUG" option, and could not see any relevant errors. I've also re-installed Caldera in a fresh directory doing a new git clone command - same result.

Please let me know if I can provide any other information that would be useful for reproducing or troubleshooting this issue. I'm trying to complete the training and I'm stuck on this step.

@github-actions
Copy link

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

@Quickswitches
Copy link

Same thing here, also using kali and firefox so guess the issue is there somewhere?

@Quickswitches
Copy link

Also just tried installing and using chrome but no change so doesn't seem to be the browser but kali itself?

@Quickswitches
Copy link

Just installed Caldera on a Ubuntu VM and it works fine there so guessing an issue with kali somehow

@heyquentin
Copy link

Same issue here. No button. I'm running Parrot 5.2 with Firefox 102.7. I'll try a Ubuntu build

@heyquentin
Copy link

Spun up a new Ubuntu Server 22.04 vm and installed Caldera via git. Same issue, there's no button in the Manual mode. Tried different browsers and there's no change, button still missing.

@heyquentin
Copy link

Tried the Docker build. Button still missing.

@elegantmoose
Copy link
Contributor

Looking into.

@elegantmoose
Copy link
Contributor

Yep, was able to replicate bug.

@elegantmoose elegantmoose mentioned this issue Feb 17, 2023
8 tasks
@elegantmoose
Copy link
Contributor

elegantmoose commented Feb 17, 2023

@heyquentin @Quickswitches @pbmilley @IGNFIfortrue - Patched. Pull down master branch, check if fix works for you, LMK if not.

@pbmilley
Copy link

Yes, it's working for me now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants