Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d arrows and Gallery #1374

Closed
Rusachok opened this issue Jul 13, 2024 · 9 comments
Closed

3d arrows and Gallery #1374

Rusachok opened this issue Jul 13, 2024 · 9 comments
Labels
Milestone

Comments

@Rusachok
Copy link

Describe the bug

When I use Gallery and 3d arrows to the next point, I have a problem. I can't click on arrow - see screen below.

image

Online demo URL

https://vi-tour.ru/s/qyjtbuht/

Photo Sphere Viewer version

5.8.2

Plugins loaded

No response

OS & browser

Win10, Chrome

Additional context

No response

@Rusachok Rusachok added the bug label Jul 13, 2024
@mistic100
Copy link
Owner

What solution do you propose ?

@Rusachok
Copy link
Author

The same as for collapsing plan button.
#1372

I think, all arrows have to be above the gallery.

@mistic100
Copy link
Owner

mistic100 commented Jul 13, 2024

I don't agree. The fix for #1372 was not to make the plan/map above the gallery but to hide the gallery when the map/plan is maximized.

This is not applicable here. Having the arrows above the gallery would be very odd.

@Rusachok
Copy link
Author

The fix for #1372 was not to make the plan/map above the gallery but to hide the gallery when the map/plan is maximized.

It's a pity. I hope it would be a smaller size for map, when gallery is visible.

So, there is a problem with 3d-arrows. Current usage is not comfortable. I can only change arrows to 2d. :(

@mistic100
Copy link
Owner

Add this to your stylesheet

.psv-virtual-tour-arrows {
  margin-bottom: 100px;
}

This is an abritrary fix I cannot really make generic but it should solve it for you.


Unless you have a more generic proposal, which I don't have.

@Rusachok
Copy link
Author

I think it is necessary to support the interaction between the Gallery and the VirtualTour.
In the function of showing gallery, you need to add an upward shift of the arrows to the height of the previews.
In the function of hiding gallery, you need to add a shift of the arrows back to the standard place.
If the gallery is not active, then nothing will move. If there are no arrows, but there is a gallery, then nothing will break either.
On the phone, the gallery takes up the entire screen, so that the arrows are not visible when displaying the gallery. Their shift won't break anything.

@mistic100
Copy link
Owner

demo of interactions between map, gallery and virtual-tour UI elements

screen-capture.webm

@mistic100 mistic100 added this to the 5.8.3 milestone Jul 15, 2024
@Rusachok
Copy link
Author

You're great! Thanks!
When are you planning to release 5.8.3?

Copy link

This feature/bug fix has been released in version 5.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants