Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通知一覧APIで、フィルタ処理で0件だった場合でも1回で諦めずにDBから情報を取得してほしい #13413

Closed
1 task
tamaina opened this issue Feb 19, 2024 · 3 comments · Fixed by #13836
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR

Comments

@tamaina
Copy link
Contributor

tamaina commented Feb 19, 2024

Summary

通知一覧APIではなるべく何か取得できるかDBの内容が尽きるまで通知を返すことを試してほしい

Purpose

if (notifications.length === 0) {
return [];

length === 0の場合、その先の通知が全く読めなくなりそうなので

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@tamaina tamaina added the ✨Feature This adds/improves/enhances a feature label Feb 19, 2024
@tamaina
Copy link
Contributor Author

tamaina commented Feb 19, 2024

(とはいえnotification-groupedはEXTRA_LIMITで100とってきてるのでさほど問題にはならないか

@Sayamame-beans
Copy link
Member

@anatawa12
Copy link
Member

Fixed in #13836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants