Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login failures on URLs with characters needing URI-encoding #48

Closed
alt36 opened this issue Aug 11, 2017 · 0 comments
Closed

Login failures on URLs with characters needing URI-encoding #48

alt36 opened this issue Aug 11, 2017 · 0 comments

Comments

@alt36
Copy link
Contributor

alt36 commented Aug 11, 2017

I'm using r4032login to automatically redirect to raven/login. If I have a URL with e.g. spaces, the login fails and hits https://github.com/misd-service-development/drupal-raven/blob/master/raven.module#L274 . By way of example, the following should be visible to anyone who has Raven-authenticated:

http://www.ch.cam.ac.uk/intranet/system/chemistry_raven_downloads/foo%20bar

but if one follows the above link, note that the &params= query param on the Raven login page is

&params=http%3A//www.ch.cam.ac.uk/intranet/system/chemistry_raven_downloads/foo%2520bar

so the % in the URI-encoded space looks to have been URI-encoded, mangling the URL. If you're not already logged in to Raven, this provokes a "Warning: Raven authentication failure."

Analysis will follow with a pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant