Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support destination URLs with query strings #46

Closed
JKingsnorth opened this issue Oct 29, 2015 · 1 comment · Fixed by #49
Closed

Support destination URLs with query strings #46

JKingsnorth opened this issue Oct 29, 2015 · 1 comment · Fixed by #49

Comments

@JKingsnorth
Copy link
Contributor

Currently URLs with query strings are not supported as final destinations, eg:
/user/login?destination=page%3Freset%3D1

The module fails on the raven_signature_check on line 205, producing a 'raven authentication failure' error message.

I think this is because we're trying to url decode the data, which is causing a mismatch because of the special characters it generates, which is broken by the base64_decode.

Removing the url decode from the raven_signature_check seems to fix the issue. PR incoming.

@JKingsnorth
Copy link
Contributor Author

#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant