Cstruct.blit_to_string uses bytes?

[samoht]

In version 3.2.1, blit_to_string has the wrong signature:

val blit_to_string: t -> int -> bytes -> int -> int -> unit

We should either remove that (deprecated) function or provides something which actually uses a string, even if I don't know exactly what that means in this case. Probably something like unsafe_blit_to_string?

[emillon]

blit_to_string is marked as a deprecated (since 2015) alias to blit_to_bytes, so I think it's safe to delete.

[XVilka]

So this one can be closed, right?

[emillon]

Yes, I think so!

[hannesm]

the @deprecated ocamldoc attribute didn't lead to OCaml compiler warnings, also blit_to_string is still used quite a bit. I'd propose to merge #251 which uses [@@ocaml.deprecated] and remove that function from the next major version. WDYT?

[hannesm]

now that #251 is merged, I'll close this issue. thanks for the report!