Added tests to verify, that iframe switching by an id works #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aik099
changed the title
aik099
force-pushed
the
frame-switching-by-index
branch
from
7055197
to
f7a9cb2
Compare
aik099
changed the title
|
The PR now tests frame switching by an ID (added code) in addition to frame switching an a name (existing code). |
stof
reviewed
Feb 26, 2024
|
@stof , both requested changes have been made. Ready for another review. |
stof
approved these changes
Feb 27, 2024
aik099
force-pushed
the
frame-switching-by-index
branch
from
2cd9746
to
0bdf4f6
Compare
Rebased. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing tests only cover iframe switching by name. This PR adds these tests:
See minkphp/Mink#866 (PR 2 of 4)
The PhpStan correctly reports this, but I can't fix it due to the problem described in the above-mentioned issue.