Observability Platform - Add the modernisation-platform aws account as a cloudwatch data source

[mikereiddigital]

User Story

As a Modernisation Platform Engineer
I need to have access to modernisation platform aws account cloudwatch data for dashboard reports.
Currently this account is not a data source.

Value / Purpose

Gives us access to modernisation platform account cloudwatch data via grafana & so avoids the need to create & run custom scripts.

Context / Background

The modernisation platform account does not have a cloudwatch data source in the Observability Platform.

Useful Contacts

No response

Additional Information

No response

Definition of Done

• Add the modernisation platform account as a cloudwatch data source
• Test & confirm working.

[ASTRobinson]

Step 1 completed - #8721

but have run into an issue with step 2 ministryofjustice/modernisation-platform-environments#9042 as the modernisation platform isn't listed within the account_ids block in the environment_management secret.

[ASTRobinson]

Following on from the investigation into adding the Modernisation Platform (MP) account to the environment_management secret, which turned out to be not feasible due to potential conflicts with other workflows, I have been working on an alternative approach. The goal was to merge the MP account details with the secret into a new variable, merged_account_ids, and use this variable in the tenant_configuration and relevant modules.

The plan seemed straightforward, but the Terraform plan output is showing unexpected changes. Here's a breakdown of the current status:

Steps Taken:

1. Merging MP Account into merged_account_ids:

• I attempted to merge the MP account details into a new variable called merged_account_ids, as defined in the platform_locals.tf.
• This variable is intended to hold all relevant account IDs, including the MP account, to be passed to the relevant modules.

2. Passing merged_account_ids to Tenant Configuration:

• The merged variable was then passed to the tenant_configuration module as the environment_management argument.
• The variable is also referenced in relevant modules to ensure the MP account is included in the configuration.

Outstanding Issues:

The integration of the MP account with the other accounts via the merged_account_ids variable still requires further investigation. We need to confirm that the merging process works as expected and that the variable is correctly passed through to avoid unnecessary changes in the plan.
The unexpected changes in the Terraform plan will require further debugging and might involve adjusting the way the merged_account_ids variable is merged or handled

[ASTRobinson]

Branch i've been working on ministryofjustice/modernisation-platform-environments#9042

[ASTRobinson]

moving to review as the Modernisation-Platform has been successfully onboarded and the cloudwatch datasource is now available in Grafana:

[markgov]

all tasks complete