Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on PR if a large number of resources are going to be destroyed #8606

Closed
1 task
davidkelliott opened this issue Nov 26, 2024 · 1 comment
Closed
1 task

Comments

@davidkelliott
Copy link
Contributor

User Story

As an MP engineer
I want to be warned if a plan is going to destroy a large number of resources
So that I don't accidentally destroy a large number of resources

Value / Purpose

Prevent accidental destroys of large number of resources

Context / Background

We recently had an incident caused by an unexpected apply which destroyed a large number of resources. The code in question what not thought to be related to this workflow and multiple plans were run against that particular workflow so the focus was on the relevant plans and that plan wasn't checked. A warning in the PR that a large number of resources were about to be destroyed would have prevented this.

Useful Contacts

No response

Additional Information

We may want to post the summary of each plan in the PR if we are going to be doing this as well.

Definition of Done

  • Workflows updated to warn on large destroys
@SimonPPledger
Copy link
Contributor

this is a duplicate

@SimonPPledger SimonPPledger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@github-project-automation github-project-automation bot moved this from To Do to Done in Modernisation Platform Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants