Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand over Oracle licensing work from root account to modernisation platform #8023

Closed
2 of 3 tasks
davidkelliott opened this issue Sep 23, 2024 · 13 comments
Closed
2 of 3 tasks
Assignees
Labels
cost savings enhancement New feature or request

Comments

@davidkelliott
Copy link
Contributor

davidkelliott commented Sep 23, 2024

User Story

There was a PoC completed in the root account to discover Oracle licenses across the MoJ estate. This work needs to be completed and moved in to production for all MP accounts.

See here for overview of solution - https://aws.amazon.com/blogs/mt/centrally-track-oracle-database-licenses-in-aws-organizations-using-aws-license-manager-and-aws-systems-manager/

See existing work here - https://github.com/ministryofjustice/aws-root-account/blob/main/organisation-security/terraform/license-manager.tf

This story is to hand over the PoC from @davidkelliott and take it into the MP.

Value / Purpose

Realise the value of the work already done and make sure it is updated and maintained.

Useful Contacts

@davidkelliott

Additional Information

No response

Definition of Done

  • Hand over from David Elliott
  • Update solution so that it is working and production ready
  • Document solution for users
@markgov
Copy link
Contributor

markgov commented Oct 23, 2024

Had a Meeting with Dave Eto talk about the issue going to look at what is currently in place on the root account

@markgov
Copy link
Contributor

markgov commented Oct 31, 2024

Looked at the cloudformation and possible fix to implement it on example account on it's own just in the process of testing at the moment

@markgov
Copy link
Contributor

markgov commented Nov 6, 2024

After applying an update to the cloud formation the workflow failed with the following error

│ Error: waiting for CloudFormation Stack (arn:aws:cloudformation:eu-west-2:***:stack/OracleDbLTS/e0b4ffe0-256f-11ee-ab44-0ac49305d196) update: timeout while waiting for state to become 'CREATE_COMPLETE, UPDATE_COMPLETE, UPDATE_ROLLBACK_COMPLETE, UPDATE_ROLLBACK_FAILED' (last state: 'UPDATE_IN_PROGRESS', timeout: 30m0s)

│ with aws_cloudformation_stack.oracleblts,
│ on license-manager.tf line 47, in resource "aws_cloudformation_stack" "oracleblts":
│ 47: resource "aws_cloudformation_stack" "oracleblts" {


Error: Terraform exited with code 1.
Error: Process completed with exit code 1.

i have created a new PR which increases the timeout for the cloud formation stack

@markgov
Copy link
Contributor

markgov commented Nov 6, 2024

@markgov
Copy link
Contributor

markgov commented Nov 8, 2024

created a PR which fixs the poc ssm association so that it runs on a schedule
ministryofjustice/aws-root-account#1027

@markgov
Copy link
Contributor

markgov commented Nov 12, 2024

Unfortunately there was an error in the cloud formation code from aws i am in the process of debugging there code to make a clean run

@markgov
Copy link
Contributor

markgov commented Nov 14, 2024

New Pr sent up to change the way the yaml file is processed
ministryofjustice/aws-root-account#1030

@markgov
Copy link
Contributor

markgov commented Nov 18, 2024

Still having issues with file name length created a new PR with a shortened file name but that has failed as well need to look into this more as i think it is the s3_object upload that is failed and it due to the source being more than 255 char long

@markgov
Copy link
Contributor

markgov commented Nov 26, 2024

Going to move to blocked until i can talk to Bhat, Praveen on the 2nd of december

@markgov
Copy link
Contributor

markgov commented Dec 5, 2024

After talking with AWS they helped me update the template to get it work, this was initially failing due to a missing script on the artifact bucket i uploaded the missing script and fired off the discovery again which turned all the failed job into successful jobs and i was able to find two new instances in Athena

@markgov
Copy link
Contributor

markgov commented Dec 5, 2024

@markgov
Copy link
Contributor

markgov commented Dec 6, 2024

Documentation PR created for this issue see PR #8705

@markgov
Copy link
Contributor

markgov commented Dec 10, 2024

documentation complete issue complete new issue raised for the addition of more accounts

@markgov markgov closed this as completed Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Modernisation Platform Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cost savings enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants