Unit Tests for SecurityHub-alarms module in Baselines

[richgreen-moj]

User Story

As a MP Engineer
I need to write some unit tests for the SecurityHub-alarms sub-module in the Baselines module
So that I can increase the confidence in the modules

Value / Purpose

As a follow-on from #6490 this ticket is to add missing unit tests for some of the sub-modules in the MP Baselines module.

Useful Contacts

@richgreen-moj

Additional Information

No response

Proposal / Unknowns

No response

Definition of Done

• Missing unit tests added
• New unit tests pass
• Another team member has reviewed

[richgreen-moj]

Branch created https://github.com/ministryofjustice/modernisation-platform-terraform-baselines/tree/feature/7309-sechub-alarms-unit-tests

[richgreen-moj]

Unit tests added for the securityhub-alarms module. The main changes to the underlying module is just adding in variables for all the resource names so that they are not duplicated when running the unit tests. These are then all defaulted to the original values so that it won't affect accounts with baseline resources already built.

I've also had to add some outputs to facilitate the testing and have added a new TestTerraformSecurityHubAlarms testing function in the baselines_test.go file

[richgreen-moj]

New version of the baselines module has been released v7.6.3 and this has now been deployed via #7684