Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Failing Run Go Unit Tests #6387

Closed
ASTRobinson opened this issue Mar 4, 2024 · 2 comments
Closed

🐛 Failing Run Go Unit Tests #6387

ASTRobinson opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ASTRobinson
Copy link
Contributor

ASTRobinson commented Mar 4, 2024

Expected Behavior

Run Go Unit Tests run and complete successfully

Example here: https://github.com/ministryofjustice/modernisation-platform-github-oidc-role/actions/runs/8108945787

Actual Behavior

Run Go Unit Tests is failing with 'ParameterNotFound' error.

Example here: https://github.com/ministryofjustice/modernisation-platform-github-oidc-role/actions/runs/8142321400

Steps to Reproduce the Problem

Create a new PR on the modernisation-platform-github-oidc-role repo.

also spotted the same error on following repositories:
modernisation-platform-terraform-s3-bucket-replication-role
modernisation-platform-terraform-pagerduty-integration

@ASTRobinson ASTRobinson added the bug Something isn't working label Mar 4, 2024
@dms1981 dms1981 moved this from To Do to In Progress in Modernisation Platform Mar 5, 2024
@dms1981 dms1981 self-assigned this Mar 5, 2024
@dms1981
Copy link
Contributor

dms1981 commented Mar 5, 2024

Having taken a quick look, it appears that the SSM parameter is missing from the account and that this bug isn't a problem related to the unit-test code in this repository. I'll do some git archaeology in https://github.com/ministryofjustice/modernisation-platform/tree/main/terraform/environments/testing and see what I can find.

@dms1981
Copy link
Contributor

dms1981 commented Mar 5, 2024

By re-running the member-bootstrap code against testing-test I recreated the missing parameter.

I could see that it was deleted in this CloudTrail Event in the testing-test account: https://eu-west-2.console.aws.amazon.com/cloudtrailv2/home?region=eu-west-2#/events/d685c8b6-cef8-4ac9-86f3-b2a2736b2b02
It looks like it was removed by a GitHub action in the modernisation-platform-environments repository - aws-nuke.
It would have been recreated by our scheduled baseline job but I think we just got caught out here by the order of operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants