Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write certification creation module for members #4058

Closed
7 of 8 tasks
markgov opened this issue May 30, 2023 · 9 comments
Closed
7 of 8 tasks

Write certification creation module for members #4058

markgov opened this issue May 30, 2023 · 9 comments
Assignees

Comments

@markgov
Copy link
Contributor

markgov commented May 30, 2023

User Story

As a modernisation platform engineer
I want to be able to quickly create dns records with certificates that can be attached to load balancers or other resources
So that we have a consistent way of creating theses services

User Type(s)

Assumptions / Hypothesis / Questions / Unknowns

Additional information to explain approach taken

Hypothesis

If we create a module with everything in will it be overly complicated

Proposal

The proposal is to try and cover some if not all of the following scenarios
(preferred option) Non production uses mp domains and ACM certificates, production uses delegated hosted zone domain and ACM certificates
Non production uses mp domains and ACM certificates, production uses 3rd party DNS forwarded to MP domains and ACM certificates
Non production uses uses delegated hosted zone and ACM, production uses delegated hosted zone domain and ACMs certificates

Below is a nice to have but not required as there is more involved in importing the gandi certificates
(preferred option if Gandi needed) Non production uses mp domains and ACM certificates, production uses delegated hosted zone domain and Gandi certificates
Non production uses uses delegated hosted zone and Gandi, production uses delegated hosted zone domain and Gandi certificates

Unknowns

Potential pitfalls that could cause the story to expand beyond its original scope. Ideally this section will remain blank.

Definition of done

  • module created
  • readme has been updated
  • user docs have been updated
  • Tested in example
  • Terratests written and passing, to cover all certificate types
  • another team member has reviewed
  • tests are green
  • UR test OR added to continual research plan

Reference

How to write good user stories

@SimonPPledger SimonPPledger changed the title Creating DNS Module Write certification creation module for members Jul 6, 2023
@markgov markgov self-assigned this Apr 16, 2024
@markgov markgov moved this from To Do to In Progress in Modernisation Platform Apr 22, 2024
@markgov
Copy link
Contributor Author

markgov commented Apr 30, 2024

PR created with new code and new unit test ministryofjustice/modernisation-platform-terraform-dns-certificates#249

i believe i have a module that will at least create a certificate at the moment i am currently having issues with the creation of the dns validation record with it being too long.

@markgov
Copy link
Contributor Author

markgov commented May 7, 2024

Terraform code is now working as expected but the go test is now not working

@markgov
Copy link
Contributor Author

markgov commented May 13, 2024

tested in example and works as intended

@markgov
Copy link
Contributor Author

markgov commented May 14, 2024

terratest scaled down and runs locally

@markgov
Copy link
Contributor Author

markgov commented May 14, 2024

@ASTRobinson if currently looking at the issue as to why the terratest fails in a git hub workflow but runs fine locally

@markgov
Copy link
Contributor Author

markgov commented May 14, 2024

@markgov
Copy link
Contributor Author

markgov commented May 21, 2024

PR merged and new PR created to update the readme to show usage instructions

@markgov
Copy link
Contributor Author

markgov commented May 21, 2024

put a meeting in on the calendar for demo of module

@markgov
Copy link
Contributor Author

markgov commented May 23, 2024

Demo done module created

@markgov markgov closed this as completed May 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Modernisation Platform May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants