From 650022b64ba4b2e2da34d3c4528dc5d295f88697 Mon Sep 17 00:00:00 2001 From: andyrogers1973 Date: Thu, 30 May 2024 15:37:31 +0100 Subject: [PATCH 1/4] Add an external collaborator Gregory Whiting will be given access to yjaf-terraform repo --- terraform/yjaf-terraform.tf | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/terraform/yjaf-terraform.tf b/terraform/yjaf-terraform.tf index e509d9172..ad98eccdc 100644 --- a/terraform/yjaf-terraform.tf +++ b/terraform/yjaf-terraform.tf @@ -32,5 +32,15 @@ module "yjaf-terraform" { added_by = "mick.ewers@yjb.gov.uk" review_after = "2025-03-14" }, + { + github_user = "gregi2n" + permission = "admin" + name = "Gregory Whiting" + email = "greg.whiting@necsws.com" + org = "NEC Software Solutions" + reason = "Devops guys need access to make app/infra changes" + added_by = "andy.rogers@digital,justice,gov.uk" + review_after = "2025-05-23" + } ] } From 7748f7474e9b6e125b04308b329c26fefeaeee07 Mon Sep 17 00:00:00 2001 From: andyrogers1973 Date: Thu, 30 May 2024 15:42:28 +0100 Subject: [PATCH 2/4] Correct approvers email address Fixes a typo in the approvers email address (causing check to fail) --- terraform/yjaf-terraform.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/terraform/yjaf-terraform.tf b/terraform/yjaf-terraform.tf index ad98eccdc..39e720e5e 100644 --- a/terraform/yjaf-terraform.tf +++ b/terraform/yjaf-terraform.tf @@ -39,7 +39,7 @@ module "yjaf-terraform" { email = "greg.whiting@necsws.com" org = "NEC Software Solutions" reason = "Devops guys need access to make app/infra changes" - added_by = "andy.rogers@digital,justice,gov.uk" + added_by = "andy.rogers@digital.justice,gov.uk" review_after = "2025-05-23" } ] From cf874a77af03a06b17ad91dc001d0c3840749ab1 Mon Sep 17 00:00:00 2001 From: andyrogers1973 Date: Thu, 30 May 2024 15:43:19 +0100 Subject: [PATCH 3/4] Fix approvers email address Approvers email address still had a typo casuing check to fail --- terraform/yjaf-terraform.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/terraform/yjaf-terraform.tf b/terraform/yjaf-terraform.tf index 39e720e5e..738a8f232 100644 --- a/terraform/yjaf-terraform.tf +++ b/terraform/yjaf-terraform.tf @@ -39,7 +39,7 @@ module "yjaf-terraform" { email = "greg.whiting@necsws.com" org = "NEC Software Solutions" reason = "Devops guys need access to make app/infra changes" - added_by = "andy.rogers@digital.justice,gov.uk" + added_by = "andy.rogers@digital.justice.gov.uk" review_after = "2025-05-23" } ] From c611e366609bd2936a1932f924e34b49d25f5b87 Mon Sep 17 00:00:00 2001 From: andyrogers1973 Date: Fri, 31 May 2024 11:01:27 +0100 Subject: [PATCH 4/4] Update the add by email Changed the email address of the added by user to the correct user. --- terraform/yjaf-terraform.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/terraform/yjaf-terraform.tf b/terraform/yjaf-terraform.tf index 738a8f232..ee13757f5 100644 --- a/terraform/yjaf-terraform.tf +++ b/terraform/yjaf-terraform.tf @@ -39,7 +39,7 @@ module "yjaf-terraform" { email = "greg.whiting@necsws.com" org = "NEC Software Solutions" reason = "Devops guys need access to make app/infra changes" - added_by = "andy.rogers@digital.justice.gov.uk" + added_by = "David.Hall@yjb.gov.uk" review_after = "2025-05-23" } ]