Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Azure Client with datahub #2992

Closed
PriyaBasker23 opened this issue Jan 18, 2024 · 2 comments
Closed

Integrate Azure Client with datahub #2992

PriyaBasker23 opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels

Comments

@PriyaBasker23
Copy link
Contributor

PriyaBasker23 commented Jan 18, 2024

User Story

As an Azure AD (AAD) evangelist
I need to register DataHub as an app in AAD
So that users can Auth via AAD to log into DataHub

Proposal

Configuring Azure Authentication for React App (OIDC)

Name the new one 'data-platform-datahub-dev'?

This app will likely use client credential flow for login, whereby the DataHub instance stores the client secret.

When these are obtained the existing azure-secrets kubernetes secret should be deleted

The client id, client secret and discovery uri (https://login.microsoftonline.com/{tenant_id}/v2.0/.well-known/openid-configuration)
should be stored within the azure-secrets secret that should exist in the cloud platform. Each should be named as the following keys

  • client id = auth_oidc_client_id
  • client secret = auth_oidc_client_secret
  • discovery uri = auth_oidc_discovery_uri

once loaded to aws secrets the should flow through to k8s secrets

Definition of Done

DataHub auth flow tested and working

Copy link
Contributor

github-actions bot commented Apr 6, 2024

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

@github-actions github-actions bot added the stale label Apr 6, 2024
Copy link
Contributor

This issue is being closed because it has been open for a further 7 days with no activity. If this is still a valid issue, please reopen it, Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done ✅
Development

No branches or pull requests

5 participants