Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create addon for persistence volume creation #671

Closed
hferentschik opened this issue Apr 5, 2017 · 8 comments
Closed

Create addon for persistence volume creation #671

hferentschik opened this issue Apr 5, 2017 · 8 comments

Comments

@hferentschik
Copy link
Member

hferentschik commented Apr 5, 2017

This might be temporary and be replaced/changed when we get persistence volumes as part of cluster up

@jorgemoralespou
Copy link
Contributor

@hferentschik look into how oc-cluster sets up PV. It's as easy as running a job. Or you can explore how I do it in the oc-cluster which don't require jobs.

@hferentschik
Copy link
Member Author

+1

@praveenkumar praveenkumar self-assigned this Apr 10, 2017
@LalatenduMohanty
Copy link
Member

So seems like we can just point --host-pv-dir = /var/lib/minishift/openshift.local.pv for oc cluster up and it will create the directories which can be used for PV. Refer [1]

[1] openshift/origin#12456

@jorgemoralespou
Copy link
Contributor

@LalatenduMohanty still I think an addon can provide benefit as this are the default 100 PVs that get created with "oc cluster".
There might be cases where you want to create the PVs in the host folder you share with the VM, or with a different type of options. I would not discard still adding some user experience, as if I could, I would just not create those 100 PVs by default, which takes some time to process.

@csrwng
Copy link

csrwng commented Apr 10, 2017

@jorgemoralespou the pv provisioning happens entirely in the background, but you can start using them as soon as the first pv is created. What's the downside?

@jorgemoralespou
Copy link
Contributor

jorgemoralespou commented Apr 11, 2017

@csrwng as I mentioned before, this creates 100 directories in my host for each cluster I start, which although in the background is something it don't make me happy. I would rather prefer to control the amount or have less (max 20). Also, I can't modify any of the options for these (e.g. annotate with a service class, prebound volume,...) so I need to have the ability to set these. I still need a command that let's me be more expressive with the volumes I create.
But most of this is personal preference.

@hferentschik hferentschik removed this from the v1.0.0-rc.2 milestone Apr 13, 2017
@praveenkumar
Copy link
Contributor

@hferentschik Can we close this issue now?

@hferentschik
Copy link
Member Author

Let's close it for now. We have been talking about being able to skip the 'cluster up' persistence volume creation and doing it more explicitly in an add-on. However, as long as 'cluster up' dies create the persistent volumes regardless, we should be using them. We can create a new issue in case we want to look into this later again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants