-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Optifine #20
Comments
Hello! Thank you for supporting this project! Optifine is not currently supported through any addon, however this is a great idea of add-on. |
@jugendhausldbg You can install Optifine with Fabric. |
Yes, optifine with fabric is a good idea. If you really want optifine only you can use the optifine installer and then use the version name (something like |
I contacted sp614x (OptiFine's author) to ask him for permission to make an addon like this. He's ok if and only if OptiFine is not bundled nor distributed with PortableMC's package. Hopefully, he seems ok with the idea of an add-on that will download the mod from the website. This message is just a note for the future, the add-on is not in development for now. |
Btw If you need a way to download Optifine and list all of Optifine versions. I could provide you with the API. |
Yes why not it would be cool because my current idea is to parse the web page, which is not really easy and lightweight. |
Who is maintaining the API? |
@mindstorm38 https://rapidapi.com/user/nitroxenon. The website is broken I used backdoor requests to subscribe to the API. |
hello! I'm a shader developer, and a moderater over on the shaderLABS discord. As for an API, major releases are few and far between, so hosting and maintaining a list of URLs somewhere online would be trivial. just Regardless, if you would like any assistance regarding optifine (including downloading) head over to the shaderLABS discord server |
Thank you for support! I'll definitely look into it in the future |
@WoMspace It is not that hard to ask the user to install it manually. |
I wonder if PMC supports optifine yet, because it seems like this request is still open. Anyway long ago I provided the api for getting optifine but it is not well maintained. Optifine author seems to be fine about it and he also gives me a direct mirror link for downloading the file. |
Optifine is not yet supported, and I still wonder if this is a good idea, mainly because Optifine in itself can be installed really quickly as a forge mod, and forge can be installed really easily now... This is not definitive, and I'm still opened to arguments, because I'm afraid it will require some hard work. |
It doesn't require much work to implement this. Just download and write optifine into the user mod folder if they run it with forge especially the version that fabric doesn't support. This saves so much time in some cases instead of opening the browser every time u want optifine on a different version. Caches downloaded optifine if possible if the user doesn't have internet, this may help in case users don't save their own. (Caches doesn't mean bundle the file so it is probably safe to do it). More than that you can also make an optifine standalone installation too if u have some free time. Launch optifine directly without forge. This gonna take a while to wrap everything. |
For now, I'll stay away from the mess of managing the "mods" directory, because this would require checking for already installed version, disabling old one, all of this is not trivial at all because mods are not uniquely defined by the file name. So it seems way more realistic to me to support standalone installation, even if this is still complicated in itself. |
I wrote a complete install script for optifine which works together with portablemc. If you are interested (the script is currently tested with more than 20 different version, but as I coded it very recently, I can't say that it is stable). If you are interested , I can post it. |
Wow, insane! I'm really interested in seeing that if you agree. It's in Python, using the API? Or a bash script around the CLI? |
It's a dirty python rewrite of the decompiled optifine installer with additionnal features, using the API of portablemc. I can send it today, but I'll try to cleanup it before sending it in the week. |
Hi there,
is it possible to add support for Optifine, or is there already a way to enable Optifine?
thanks for your amazing work
The text was updated successfully, but these errors were encountered: