Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compiling RmlUI 5.1 with current version of MSYS2 #555

Closed
barotto opened this issue Dec 27, 2023 · 4 comments
Closed

Error compiling RmlUI 5.1 with current version of MSYS2 #555

barotto opened this issue Dec 27, 2023 · 4 comments
Labels
build Build system and compilation duplicate This issue or pull request already exists

Comments

@barotto
Copy link
Contributor

barotto commented Dec 27, 2023

Using the current version of the MSYS2 build environment on Windows (gcc 13.2.0), compilation of RmlUi 5.1 fails with the following error:

In file included from C:/workspace/RmlUi/Source/Core/ElementAnimation.cpp:40:
C:/workspace/RmlUi/Source/Core/ElementStyle.h:43:6: warning: elaborated-type-specifier for a scoped enum must not use the 'class' keyword
   43 | enum class PseudoClassState : std::uint8_t { Clear = 0, Set = 1, Override = 2 };
      | ~~~~ ^~~~~
      |      -----
C:/workspace/RmlUi/Source/Core/ElementStyle.h:43:12: error: use of enum 'PseudoClassState' without previous declaration
   43 | enum class PseudoClassState : std::uint8_t { Clear = 0, Set = 1, Override = 2 };
      |            ^~~~~~~~~~~~~~~~

This can be resolved including cstdint in Include/RmlUi/Core/Types.h:

#include <cstdint>
@mikke89 mikke89 added the build Build system and compilation label Dec 27, 2023
@mikke89
Copy link
Owner

mikke89 commented Dec 27, 2023

Hey, and thanks for reporting. This looks like a duplicate of #470 and #545, already fixed in master branch.

@mikke89 mikke89 added the duplicate This issue or pull request already exists label Dec 27, 2023
@barotto
Copy link
Contributor Author

barotto commented Dec 28, 2023

Thanks, unfortunately I have to use 5.1 as master completely breaks my UI.

@mikke89
Copy link
Owner

mikke89 commented Dec 28, 2023

Yeah, there have been some layout changes. I hope it's not too much trouble to upgrade, let me know if I can help with that.

In any case, I'm closing this one. It should be possible to apply this patch to 5.1, at least manually: 313cbab

@mikke89 mikke89 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
@barotto
Copy link
Contributor Author

barotto commented Dec 28, 2023

Thank you very much for the link to the patch.

Though CMake is already giving me deprecation warnings so I'm afraid I won't have a choice but to upgrade soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and compilation duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants