Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgbox] Extraction error, site change (late 2017) #47

Closed
Hrxn opened this issue Oct 31, 2017 · 2 comments
Closed

[imgbox] Extraction error, site change (late 2017) #47

Hrxn opened this issue Oct 31, 2017 · 2 comments
Labels

Comments

@Hrxn
Copy link
Contributor

Hrxn commented Oct 31, 2017

First, congratulations on 1.0.0 . Really good job! 😉

Imgbox is not working atm, caused by a site change, as confirmed by Google Web Search turning up issues for this site with other programs etc.

gallery-dl 1.0.0
Windows 10 x64 Fall Creators Update
Python 3.6.1 x64

Imgbox, Test URL 1:
http://imgbox.com/g/cUGEkRbdZZ

PS D:\> gallery-dl --verbose "http://imgbox.com/g/cUGEkRbdZZ"
[gallery-dl][debug] Version 1.0.0
[gallery-dl][debug] Python 3.6.1 - Windows-10-10.0.16299-SP0
[gallery-dl][debug] Starting DownloadJob for 'http://imgbox.com/g/cUGEkRbdZZ'
[imgbox][debug] Using ImgboxGalleryExtractor for http://imgbox.com/g/cUGEkRbdZZ
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): imgbox.com
[urllib3.connectionpool][debug] https://imgbox.com:443 "GET /g/cUGEkRbdZZ HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://imgbox.com:443 "GET /fFnvPLeZ HTTP/1.1" 200 None
[imgbox][error] An unexpected error occurred: TypeError - must be str, not NoneType. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[imgbox][debug] Traceback
Traceback (most recent call last):
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\job.py", line 58, in run
    for msg in self.extractor:
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\common.py", line 139, in __iter__
    raise task
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\common.py", line 146, in async_items
    for task in self.items():
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\imgbox.py", line 52, in items
    yield Message.Url, self.get_file_url(imgpage), data
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\imgbox.py", line 78, in get_file_url
    return base + path
TypeError: must be str, not NoneType
PS D:\>

Imgbox, Test URL 2:
https://imgbox.com/g/m3hiqHrE0e

PS D:\> gallery-dl --verbose "https://imgbox.com/g/m3hiqHrE0e"
[gallery-dl][debug] Version 1.0.0
[gallery-dl][debug] Python 3.6.1 - Windows-10-10.0.16299-SP0
[gallery-dl][debug] Starting DownloadJob for 'https://imgbox.com/g/m3hiqHrE0e'
[imgbox][debug] Using ImgboxGalleryExtractor for https://imgbox.com/g/m3hiqHrE0e
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): imgbox.com
[urllib3.connectionpool][debug] https://imgbox.com:443 "GET /g/m3hiqHrE0e HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://imgbox.com:443 "GET /pvWHIHlp HTTP/1.1" 200 None
[imgbox][error] An unexpected error occurred: TypeError - must be str, not NoneType. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[imgbox][debug] Traceback
Traceback (most recent call last):
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\job.py", line 58, in run
    for msg in self.extractor:
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\common.py", line 139, in __iter__
    raise task
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\common.py", line 146, in async_items
    for task in self.items():
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\imgbox.py", line 52, in items
    yield Message.Url, self.get_file_url(imgpage), data
  File "c:\users\hrxn\appdata\local\programs\python\python36\lib\site-packages\gallery_dl\extractor\imgbox.py", line 78, in get_file_url
    return base + path
TypeError: must be str, not NoneType
PS D:\>

Well, fuck me sideways, was just about to click on 'Submit', but then decided to try another URL..
http://imgbox.com/g/wg9TY0XSg7

And this seems to work. Oh my, even if something is broken, it has to be broken in an inconsistent manner. Obviously.

Can't tell why No. 3 is working. I think this is a rather old gallery, while the other examples are pretty new. Maybe the site change only applies to new galleries..

The other difference I can think of is the gallery title. The first two have a specific title, while no. 3 does not, only a generic 'Unnamed Gallery etc.pp.'..

@Hrxn
Copy link
Contributor Author

Hrxn commented Oct 31, 2017

Okay, probably not the title, but they definitely changed the URL scheme for the actual images..

The HTML:
1: https://gist.github.com/anonymous/4ea7d0648bf38a930ea8daf4a8221455
2: https://gist.github.com/anonymous/9126bd7fa0e2feb2af9d5c541d205cf3
3: https://gist.github.com/anonymous/3f3164d9d90ccd0e9984d6fc3e003432

@mikf mikf closed this as completed in 3a8a0c1 Nov 1, 2017
@mikf
Copy link
Owner

mikf commented Nov 1, 2017

First, congratulations on 1.0.0 . Really good job! 😉

Thank you.

… but they definitely changed the URL scheme for the actual images.

This seems to be the only site change that actually caused any problems here. Images in your first two galleries are hosted on https://images2.imgbox.com, while older(?) ones are hosted on https://i.imgbox.com, which is what was expected by gallery-dl.

@mikf mikf added the bug label Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants