[pixiv] support tag for user downloads #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Looking at this made me realize that the pixiv module really needs an overhaul. There are some minor issues with your code (regex, for example), but I'm just going to merge this as is and fix these myself while rewriting the pixiv module, if that is OK with you. |
|
Sounds good to me. I didn't really know what I was doing, just wanted the feature so I threw something together that mostly works. Looking forward to the new and improved module when you do the rewrite! And thanks for making this great tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pixiv user links can include a tag (https://www.pixiv.net/member_illust.php?id={user}&tag={tag}), which means to only show images with that tag. This PR adds support for that to the extractor.