Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?][Feature request?] postprocessors.metadata firing when set to POST even without --write-metadata flag #1583

Closed
Scripter17 opened this issue May 27, 2021 · 2 comments

Comments

@Scripter17
Copy link
Contributor

I set postprocessors.metadata to fire on post as per this comment and while it does work, shouldn't it only fire when --write-metadata is used?

If it is supposed to without the flag, then maybe allowing a "condition":"--write-metadata" in postprocessor configs would be worthwhile
This could also allow for pseduo-user defined command line flags by not limiting it to existing flags

@mikf
Copy link
Owner

mikf commented May 28, 2021

shouldn't it only fire when --write-metadata is used?

Probably, but that's not how the current post processing system works. --write-metadata only adds another metadata post processor to the list (it's possible to have more than one active at a time). There is no way to enable/disable a post processor set in a config file with a command-line switch.

What you can do is create a second config file with only the metadata post processor in it and load it with -c when you want it enabled.

@mikf
Copy link
Owner

mikf commented Jun 12, 2021

83fc4c1 and 6ecb710 should somewhat improve the post processor situation.

These make it possible to globally define your own post processors and run them with -P/--postprocessor and to overwrite the settings for the "default" post processors used by flags like --write-metadata.

I have no idea how and where to document this, though.

then maybe allowing a "condition":"--write-metadata" in postprocessor configs would be worthwhile

#1460 and 3cbbefd

@mikf mikf closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants