-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support tumblrgallery.xyz
#1298
Conversation
0770e88
to
f8de1fb
Compare
2ae8d21
to
b1cae67
Compare
@rautamiekka I am not sure what you mean. For post processing it is easy to know what is the id. If I spilt the filename by "_" I know the id with extension is the last element of the array. |
If the post contains the underscore you'll fuck up the split, and/or if the post contains an integer, it'll also fuck up the detection. For that reason, you musta all easily detectable parts before the one you can't too simply detect. I know from multiple 1st-hand experience with files I named something like that. |
I think knowing it is always the last one is safe as knowing it is always the 3rd one. but I understand it is can be confusing.
I will commit a change to put the title at the end. |
^ I'm glad you were able to see reason :) |
Is there anything I need to add to this branch to make it ready to merge? |
I am not sure how to write tests for this project please let me know if I need to change it.