Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when processing literature on DeviantArt #108

Closed
ghost opened this issue Sep 13, 2018 · 2 comments
Closed

Crashes when processing literature on DeviantArt #108

ghost opened this issue Sep 13, 2018 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 13, 2018

Hello,
Several of the DeviantArt galleries I regularly download have started crashing recently. It seems to happen whenever it tries to process a literature type post. This started happening this week; perhaps they have changed the format or something?

The error looks like this:

[deviantart][error] An unexpected error occurred: TypeError - a float is required. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[deviantart][debug] Traceback
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/gallery_dl/job.py", line 64, in run
for msg in self.extractor:
File "/usr/local/lib/python3.5/dist-packages/gallery_dl/extractor/deviantart.py", line 87, in items
yield self.commit_journal(deviation, journal)
File "/usr/local/lib/python3.5/dist-packages/gallery_dl/extractor/deviantart.py", line 120, in _commit_journal_html
date = datetime.datetime.utcfromtimestamp(deviation["published_time"])
TypeError: a float is required

@mikf mikf closed this as completed in 0232d80 Sep 13, 2018
@mikf
Copy link
Owner

mikf commented Sep 13, 2018

perhaps they have changed the format or something?

They changed the published_time field from integer to string, which caused the timestamp-to-date conversion to fail. Why they made this change in the first place this is highly questionable, but that's another topic entirely.

Anyway, thanks for reporting this bug.

@mikf mikf added the bug label Sep 13, 2018
@ghost
Copy link
Author

ghost commented Sep 13, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant