Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seiga] Support image metadata and fix cookie check. #1063

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

kurumigi
Copy link
Contributor

In niconico seiga, image page HTMLs are including metadata. I want to use metadata, so implemented. And fixed cookie check process.

@mikf mikf merged commit 7e0e872 into mikf:master Oct 15, 2020
mikf added a commit that referenced this pull request Oct 15, 2020
@mikf
Copy link
Owner

mikf commented Oct 15, 2020

Thanks for your contribution, but next time please don't "fix" a failing test by modifying it to fit your changes. (6ac568c)

_check_cookies() wants a list or tuple of cookie names, and you changed it to a string instead.

  • ("user_session") is the string user_session in parenthesis
  • ("user_session",) is a tuple with 1 element, the string user_session

The first would check for cookies named u, s, e, r and so on,
while the last would only check for one cookie named user_session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants